| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Jun 2015 17:45:37 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: Josh Wu <josh.wu@...el.com> Cc: Nicolas Ferre <nicolas.ferre@...el.com>, linux-arm-kernel@...ts.infradead.org, Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org, Russell King <linux@....linux.org.uk>, Pawel Moll <pawel.moll@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Kumar Gala <galak@...eaurora.org>, Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Andrew Victor <linux@...im.org.za> Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Hi, Seems good to me, a small comment below: On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote : > @@ -1068,8 +1076,12 @@ > clocks = <&isi_clk>; > clock-names = "isi_clk"; > pinctrl-names = "default"; > - pinctrl-0 = <&pinctrl_isi>; > + pinctrl-0 = <&pinctrl_isi_data_0_7>; I would say that the pinctrl is board specific so both pinctrl-names and pinctrl-0 should go to at91sam9m10g45ek.dts -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists