linux-kernel - Re: [PATCH 1/5] staging: ft1000-usb: Fixed some issues with lines over 80 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434642666.2689.105.camel@perches.com>
Date:	Thu, 18 Jun 2015 08:51:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Peter Karlsson <peter@...to.se>
Cc:	greg@...ah.com, marek.belisko@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] staging: ft1000-usb: Fixed some issues with lines
 over 80 characters

On Thu, 2015-06-18 at 15:50 +0200, Peter Karlsson wrote:
> Fix checkpatch warnings about lines over 80 characters.
[]
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c
[]
> @@ -414,12 +414,20 @@ static long ft1000_ioctl(struct file *file, unsigned int command,
>  	unsigned long flags;
>  	struct IOCTL_GET_VER get_ver_data;
>  	struct IOCTL_GET_DSP_STAT get_stat_data;
> -	u8 ConnectionMsg[] = {0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00, 0x93, 0x64,
> -			      0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x05, 0x00, 0x00, 0x00, 0x0a,
> -			      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> -			      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
> -			      0x00, 0x00, 0x02, 0x37, 0x00, 0x00, 0x00, 0x08, 0x00, 0x00, 0x00, 0x01, 0x00, 0x01, 0x7f, 0x00,
> -			      0x00, 0x01, 0x00, 0x00};
> +	u8 ConnectionMsg[] = {
> +		0x00, 0x44, 0x10, 0x20, 0x80, 0x00, 0x00,
> +		0x00, 0x00, 0x00, 0x03, 0x00, 0x00, 0x00,

7 bytes per line is unusual.
8 or 10 is more common.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/