lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACK8Z6HgLZ_=P4O88Jkg4gGwYHxG4=doMAWJ08_aJ716d+-wSA@mail.gmail.com>
Date:	Thu, 18 Jun 2015 10:59:27 -0700
From:	Rajat Jain <rajatja@...gle.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	linux-pci@...r.kernel.org, Yinghai Lu <yinghai@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] PCI: pciehp: Rename queue_interrupt_event() to pciehp_queue_interrupt_event()

On Thu, Jun 18, 2015 at 9:12 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> Rename queue_interrupt_event() to pciehp_queue_interrupt_event() so we can
> make it extern and call it from pcie_isr().
>
> No functional change.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Ok to add:
Reviewed-by: Rajat Jain <rajatja@...gle.com>

> ---
>  drivers/pci/hotplug/pciehp_ctrl.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
> index 1086041..7ed37dc 100644
> --- a/drivers/pci/hotplug/pciehp_ctrl.c
> +++ b/drivers/pci/hotplug/pciehp_ctrl.c
> @@ -37,7 +37,7 @@
>
>  static void interrupt_event_handler(struct work_struct *work);
>
> -static void queue_interrupt_event(struct slot *p_slot, u32 event_type)
> +static void pciehp_queue_interrupt_event(struct slot *p_slot, u32 event_type)
>  {
>         struct event_info *info;
>
> @@ -64,7 +64,7 @@ u8 pciehp_handle_attention_button(struct slot *p_slot)
>         ctrl_info(ctrl, "Button pressed on Slot(%s)\n", slot_name(p_slot));
>         event_type = INT_BUTTON_PRESS;
>
> -       queue_interrupt_event(p_slot, event_type);
> +       pciehp_queue_interrupt_event(p_slot, event_type);
>
>         return 0;
>  }
> @@ -90,7 +90,7 @@ u8 pciehp_handle_switch_change(struct slot *p_slot)
>                 event_type = INT_SWITCH_CLOSE;
>         }
>
> -       queue_interrupt_event(p_slot, event_type);
> +       pciehp_queue_interrupt_event(p_slot, event_type);
>
>         return 1;
>  }
> @@ -120,7 +120,7 @@ u8 pciehp_handle_presence_change(struct slot *p_slot)
>                 event_type = INT_PRESENCE_OFF;
>         }
>
> -       queue_interrupt_event(p_slot, event_type);
> +       pciehp_queue_interrupt_event(p_slot, event_type);
>
>         return 1;
>  }
> @@ -133,7 +133,7 @@ u8 pciehp_handle_power_fault(struct slot *p_slot)
>         ctrl_err(ctrl, "Power fault on slot %s\n", slot_name(p_slot));
>         event_type = INT_POWER_FAULT;
>         ctrl_info(ctrl, "Power fault bit %x set\n", 0);
> -       queue_interrupt_event(p_slot, event_type);
> +       pciehp_queue_interrupt_event(p_slot, event_type);
>
>         return 1;
>  }
> @@ -153,7 +153,7 @@ void pciehp_handle_linkstate_change(struct slot *p_slot)
>                 event_type = INT_LINK_DOWN;
>         }
>
> -       queue_interrupt_event(p_slot, event_type);
> +       pciehp_queue_interrupt_event(p_slot, event_type);
>  }
>
>  /* The following routines constitute the bulk of the
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ