linux-kernel - Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <558308A1.6060408@suse.cz>
Date:	Thu, 18 Jun 2015 20:06:25 +0200
From:	Martin Liška <mliska@...e.cz>
To:	Ingo Molnar <mingo@...nel.org>
CC:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] perf annotate: With --show-total-period, display total
 # of samples.

On 06/18/2015 06:26 PM, Ingo Molnar wrote:
> 
> * Martin Liška <mliska@...e.cz> wrote:
> 
>> To compare two records on an instruction base, with --show-total-period
>> option provided, display total number of samples that belong to a line
>> in assembly language.
>>
>> Signed-off-by: Martin Liska <mliska@...e.cz>
>> ---
>>  tools/perf/builtin-annotate.c     |  2 ++
>>  tools/perf/ui/browsers/annotate.c | 44 +++++++++++++++++++++++++--------------
>>  tools/perf/util/annotate.c        | 28 +++++++++++++++++++------
>>  tools/perf/util/annotate.h        |  3 ++-
>>  4 files changed, 54 insertions(+), 23 deletions(-)
>>
>> diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
>> index 4e08c2d..2c1bec3 100644
>> --- a/tools/perf/builtin-annotate.c
>> +++ b/tools/perf/builtin-annotate.c
>> @@ -329,6 +329,8 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused)
>>  		   "objdump binary to use for disassembly and annotations"),
>>  	OPT_BOOLEAN(0, "group", &symbol_conf.event_group,
>>  		    "Show event group information together"),
>> +	OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period,
>> +		    "Show a column with the sum of periods"),
>>  	OPT_END()
> 
> What is the toggle for this in the 'perf report' TUI? (which displays annotated 
> output too)
> 
> Thanks,
> 
> 	Ingo
> 

Hello.

Thanks for note, I fixed that by introducing a new 't' hot key.

Thanks,
Martin

View attachment "0001-perf-annotate-With-show-total-period-display-total-o-v2.patch" of type "text/x-patch" (11015 bytes)