linux-kernel - Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 15:02:13 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Rob Landley <rob@...dley.net>, Jiri Slaby <jslaby@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Kevin Hilman <khilman@...aro.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Riku Voipio <riku.voipio@...aro.org>,
	Jiri Kosina <jkosina@...e.cz>, Paul Bolle <pebolle@...cali.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Davidlohr Bueso <davidlohr@...com>,
	Richard Weinberger <richard@....at>,
	Zhigang Lu <zlu@...era.com>,
	Vineet Gupta <vgupta@...opsys.com>,
	Richard Kuo <rkuo@...eaurora.org>,
	Max Filippov <jcmvbkbc@...il.com>,
	Pranith Kumar <bobby.prani@...il.com>,
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, ysato@...rs.sourceforge.jp
Subject: Re: [PATCH 2/2] Changes to existing files for 0PF FPGA board.

On Thu, 18 Jun 2015 10:59:31 -0700
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Thu, Jun 18, 2015 at 10:19:19AM -0700, Rob Landley wrote:
> > Changes to existing files to add 0pf j2 board support.
> > 
> 
> That's the second worse commit message and subject: line I've read
> today.

Only the second worse today? Damn, you must get a lot of crappy change
logs.

> 
> And there's no signed off by line.
> 
> And there was no 1/2 patch sent.
> 
> And, most importantly:
> 
> > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> 
> I don't care about arch/sh/ stuff, why are you sending this to me?

Because even when you don't care, you still give back constructive
feedback ;-)

-- Steve


> 
> You have a bit of work to do here...
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/