linux-kernel - Re: [PATCH 10/15] PCI: kill off set_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Jun 2015 15:08:34 -0500
From:	Rob Herring <robh@...nel.org>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"arm@...nel.org" <arm@...nel.org>,
	Kishon Vijay Abraham I <kishon@...com>,
	Murali Karicheri <m-karicheri2@...com>,
	Thierry Reding <thierry.reding@...il.com>,
	Stephen Warren <swarren@...dotorg.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Jingoo Han <jingoohan1@...il.com>,
	Pratyush Anand <pratyush.anand@...il.com>,
	Simon Horman <horms@...ge.net.au>,
	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	linux-omap <linux-omap@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	SH-Linux <linux-sh@...r.kernel.org>
Subject: Re: [PATCH 10/15] PCI: kill off set_irq_flags usage

On Thu, Jun 18, 2015 at 11:59 AM, Bjorn Helgaas <bhelgaas@...gle.com> wrote:
> On Tue, Jun 09, 2015 at 01:26:36PM -0500, Rob Herring wrote:
>> set_irq_flags is ARM specific with custom flags which have genirq
>> equivalents. Convert drivers to use the genirq interfaces directly, so we
>> can kill off set_irq_flags. The translation of flags is as follows:
>>
>> IRQF_VALID -> !IRQ_NOREQUEST
>> IRQF_PROBE -> !IRQ_NOPROBE
>> IRQF_NOAUTOEN -> IRQ_NOAUTOEN
>>
>> For IRQs managed by an irqdomain, the irqdomain core code handles clearing
>> and setting IRQ_NOREQUEST already, so there is no need to do this in
>> .map() functions and we can simply remove the set_irq_flags calls. Some
>> users also set IRQ_NOPROBE and this has been maintained although it is not
>> clear that is really needed. There appears to be a great deal of blind
>> copy and paste of this code.
>>
>> Signed-off-by: Rob Herring <robh@...nel.org>
>> Cc: Kishon Vijay Abraham I <kishon@...com>
>> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
>> Cc: Murali Karicheri <m-karicheri2@...com>
>> Cc: Thierry Reding <thierry.reding@...il.com>
>> Cc: Stephen Warren <swarren@...dotorg.org>
>> Cc: Alexandre Courbot <gnurou@...il.com>
>> Cc: Jingoo Han <jingoohan1@...il.com>
>> Cc: Pratyush Anand <pratyush.anand@...il.com>
>> Cc: Simon Horman <horms@...ge.net.au>
>> Cc: Michal Simek <michal.simek@...inx.com>
>> Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
>> Cc: linux-omap@...r.kernel.org
>> Cc: linux-pci@...r.kernel.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-tegra@...r.kernel.org
>> Cc: linux-sh@...r.kernel.org
>
> This is the only part of the series on linux-pci, so I assume this will be
> merged by somebody else along with the rest.

I copied you on the intro, but all the lists and all the maintainers
was too long to cc. Being late in the cycle I didn't really intend for
this to be for 4.2, but you can pick up this patch if you want to as
it doesn't have any dependencies. If you don't, then I will submit the
whole series for 4.3.

> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

Thanks.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/