linux-kernel - [RFC] hotkey for disabling/enabling events in 'perf top' TUI was Re: [GIT PULL 0/8] perf/core improvements and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150618201829.GF3079@kernel.org>
Date:	Thu, 18 Jun 2015 17:18:29 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	Borislav Petkov <bp@...e.de>, David Ahern <dsahern@...il.com>,
	Don Zickus <dzickus@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	He Kuang <hekuang@...wei.com>, Jiri Olsa <jolsa@...hat.com>,
	Li Zhang <zhlcindy@...ux.vnet.ibm.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Naohiro Aota <naota@...sp.net>,
	Peter Zijlstra <peterz@...radead.org>, pi3orama@....com,
	Stephane Eranian <eranian@...gle.com>,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	Wang Nan <wangnan0@...wei.com>, Zefan Li <lizefan@...wei.com>
Subject: [RFC] hotkey for disabling/enabling events in 'perf top' TUI was Re:
 [GIT PULL 0/8] perf/core improvements and fixes

Em Thu, Jun 18, 2015 at 09:40:10AM +0200, Ingo Molnar escreveu:
> * Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > User visible:

> > - Allow disabling/enabling events dynamicly in 'perf top':
> >   a 'perf top' session can instantly become a 'perf report'
> >   one, i.e. going from dynamic analysis to a static one,
> >   returning to a dynamic one is possible, to toogle the
> >   modes, just press CTRL+z. (Arnaldo Carvalho de Melo)
 
> Nice!! :-)
 
> Btw., it would be nice if the status line carried information about whether 
> collection is 'frozen' or running, at a glance. A hint might also suggest how to 
> unfreeze the session - in case someone pressed Ctrl-Z to suspend the perf top 
> session ...

Right, and I think we better find other hotkey and make Ctrl+Z work like
with other tools, i.e. suspend:

[acme@zoo linux]$ mutt

[1]+  Stopped                 mutt
[acme@zoo linux]$ vim

[2]+  Stopped                 vim
[acme@zoo linux]$ 

The perf TUI should work like that as well...

Ideas?

We already have:

h/?/F1        Show this window
UP/DOWN/PGUP
PGDN/SPACE    Navigate
q/ESC/CTRL+C  Exit browser

For multiple event sessions:

TAB/UNTAB     Switch events

For symbolic views (--sort has sym):

->            Zoom into DSO/Threads & Annotate current symbol
<-            Zoom out
a             Annotate current symbol
C             Collapse all callchains
d             Zoom into current DSO
D             Show some developer debug info
E             Expand all callchains
F             Toggle percentage of filtered entries
H             Display column headers
i             Show header information
P             Print histograms to perf.hist.N
r             Run available scripts
s             Switch to another data file in PWD
t             Zoom into current Thread
V             Verbose (DSO names in callchains, etc)
z             Toggle zeroing of samples 
/             Filter symbol by name 
 
> Also, there's now a GUI inconsistency with perf report: which will now exit on 
> Ctrl-Z. It should probably print a warning in the status line instead, that 
> freezing/unfreezing only works in 'perf top'.

I'll fix that.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/