linux-kernel - Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150619064721.GA1183@lst.de>
Date:	Fri, 19 Jun 2015 08:47:21 +0200
From:	Christoph Hellwig <hch@....de>
To:	Mike Snitzer <snitzer@...hat.com>
Cc:	Vivek Goyal <vgoyal@...hat.com>, dm-devel@...hat.com,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@....de>
Subject: Re: WARNING: at fs/block_dev.c:5 when removing LV on removed device

On Thu, Jun 18, 2015 at 03:28:21PM -0400, Mike Snitzer wrote:
> > WARN_ON_ONCE(write_inode_now(inode, true))
> > 
> > If we failed to write back inode, then warning about it sounds right?
> 
> A warning is fine.. not a WARN_ON().  Pretty alarming backtrace spew but
> maybe I'm missing something and DM's blkdev refcount mgmt couldn't
> trigger this WARN_ON()?  I fail to see how to avoid it given the device
> isn't thre so write_inode_now() fails.
> 
> > What's wrong with that? Should it be just a kernel log of level KERN_WARN
> > instead?
> 
> Ideally, but I honestly don't have all the details paged in my head to
> say definitively.  First need to answer how vitrio-blk isn't hitting
> this (and DM is).  Could it be that __blkdev_put isn't getting called
> for virtio-blk!?

Just a warnings if fine.  In fact we can probably remove that as well
as it will happen after a hot removal all the time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/