linux-kernel - Re: [PATCH] staging: media: lirc: fix coding style error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150619080232.GN28762@mwanda>
Date:	Fri, 19 Jun 2015 11:02:32 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sunil Shahu <shshahu@...il.com>
Cc:	mchehab@....samsung.com, devel@...verdev.osuosl.org,
	hamohammed.sa@...il.com, arnd@...db.de, tapaswenipathak@...il.com,
	gregkh@...uxfoundation.org, jarod@...sonet.com,
	gulsah.1004@...il.com, amber.rose.thrall@...il.com,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: media: lirc: fix coding style error

On Wed, Jun 17, 2015 at 06:01:32PM +0530, Sunil Shahu wrote:
> Fix code indentation error by replacing tab in place of spaces.
> 
> Signed-off-by: Sunil Shahu <shshahu@...il.com>
> ---
>  drivers/staging/media/lirc/lirc_sasem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_sasem.c b/drivers/staging/media/lirc/lirc_sasem.c
> index 8ebee96..12aae72 100644
> --- a/drivers/staging/media/lirc/lirc_sasem.c
> +++ b/drivers/staging/media/lirc/lirc_sasem.c
> @@ -185,7 +185,7 @@ static void deregister_from_lirc(struct sasem_context *context)
>  		       __func__, retval);
>  	else
>  		dev_info(&context->dev->dev,
> -		         "Deregistered Sasem driver (minor:%d)\n", minor);
> +			"Deregistered Sasem driver (minor:%d)\n", minor);

Not quite.  The original is:

[tab][tab][space][space][space][space][space][space][space][space][space]"Dere...

You have:

[tab][tab][tab]"Deregistered Sasem driver ...

It should be:

[tab][tab][tab][space]"Deregistered Sasem driver (minor:%d)\n", minor);

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/