linux-kernel - Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Jun 2015 21:29:34 +0900
From:	Chanwoo Choi <cwchoi00@...il.com>
To:	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
Cc:	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v3 1/7] extcon: arizona: Factor out initial GPIO state

Hi Charles,

I'm sorry about lack of my commet on previous patch.
I just want to know the what is meaning of zero(0) index of
"info->micd_modes[0] array"
instead of separate variable (gpio_initial_level).

So, I'd like you to drop this patch on next your patch-set.

Thanks,
Chanwoo Choi

On Fri, Jun 19, 2015 at 7:24 PM, Charles Keepax
<ckeepax@...nsource.wolfsonmicro.com> wrote:
> Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
> ---
>  drivers/extcon/extcon-arizona.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
> index 9262b45..e31613a 100644
> --- a/drivers/extcon/extcon-arizona.c
> +++ b/drivers/extcon/extcon-arizona.c
> @@ -1135,6 +1135,7 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>         struct arizona *arizona = dev_get_drvdata(pdev->dev.parent);
>         struct arizona_pdata *pdata = &arizona->pdata;
>         struct arizona_extcon_info *info;
> +       int gpio_initial_level;
>         unsigned int val;
>         unsigned int clamp_mode;
>         int jack_irq_fall, jack_irq_rise;
> @@ -1226,8 +1227,9 @@ static int arizona_extcon_probe(struct platform_device *pdev)
>                 info->micd_num_modes = ARRAY_SIZE(micd_default_modes);
>         }
>
> +       gpio_initial_level = info->micd_modes[0].gpio;
>         if (arizona->pdata.micd_pol_gpio > 0) {
> -               if (info->micd_modes[0].gpio)
> +               if (gpio_initial_level)
>                         mode = GPIOF_OUT_INIT_HIGH;
>                 else
>                         mode = GPIOF_OUT_INIT_LOW;
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/