linux-kernel - Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150619141945.GK3079@kernel.org>
Date:	Fri, 19 Jun 2015 11:19:45 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Lukas Wunner <lukas@...ner.de>
Cc:	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if
 prefix= is specified

Em Fri, Jun 19, 2015 at 01:54:17PM +0200, Lukas Wunner escreveu:
> Hi Jiri, Hi David,
> 
> On Fri, Jun 19, 2015 at 12:17:06AM +0200, Jiri Olsa wrote:
> > it had effect.. prefix is passed to build framework throught .config-detected
> > file as prefix_SQ variable, which is then referenced in perf Build makefiles
> 
> You're right, thanks for the clarification.

Yes, this is all very involved, lots of details, that would be great to
have in the changeset log, so that we could read it when scratching our
heads trying to understand all this :-\

Could someone, please, send a v2 with these explanations?

- Arnaldo
 
> The underlying issue is basically that the same variable name is used for
> two different things, to calculate the paths of the build targets in
> Makefile.build and to pass the install directory around between Makefiles.
> And which one "wins" depends on invocation. If we just rename the variable
> in Makefile.build, the issue is gone. That's what the patch does.
> 
> Thanks again,
> 
> Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/