linux-kernel - Re: [PATCH v2 5/9] staging: sm7xxfb: fix alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150619144514.GS28762@mwanda>
Date:	Fri, 19 Jun 2015 17:45:14 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, Joe Perches <joe@...ches.com>,
	linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/9] staging: sm7xxfb: fix alignment

On Wed, Jun 17, 2015 at 04:54:44PM +0530, Sudip Mukherjee wrote:
> @@ -346,9 +346,8 @@ static ssize_t smtcfb_read(struct fb_info *info, char __user *buf, size_t
>  		dst = buffer;
>  		for (i = c >> 2; i--;) {
>  			*dst = fb_readl(src++);
> -			*dst =
> -			    (*dst & 0xff00ff00 >> 8) |
> -			    (*dst & 0x00ff00ff << 8);
> +			*dst = (*dst & 0xff00ff00 >> 8) |
> +			       (*dst & 0x00ff00ff << 8);

This is supposed to convert __le16 to __be16?

>  			dst++;
>  		}
>  		if (c & 3) {

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/