linux-kernel - Re: [PATCH] block: cfq-iosched: fix unused 'cpd_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 19 Jun 2015 10:15:37 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Vladimir Zapolskiy <vz@...ia.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: cfq-iosched: fix unused 'cpd_to_cfqgd' function
 warning

On 06/18/2015 04:33 PM, Vladimir Zapolskiy wrote:
> If CFQ_GROUP_IOSCHED kernel option is not set, a compiler produces the
> following warning:
>
>    CC      block/cfq-iosched.o
>    linux/block/cfq-iosched.c:469:2:
>      warning: 'cpd_to_cfqgd' defined but not used [-Wunused-function]
>      *cpd_to_cfqgd(struct blkcg_policy_data *cpd)
>       ^
>
> Define this function only if CFQ_GROUP_IOSCHED is set and remove
> the compilation warning.

The two other related functions aren't used either if group scheduling 
isn't enabled. I committed this instead:

http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.2/core&id=4ceab71b9d84e55b59a76b54b2999dc377aae6e6

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/