linux-kernel - [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150619180742.62D31523@viggo.jf.intel.com>
Date:	Fri, 19 Jun 2015 11:07:42 -0700
From:	Dave Hansen <dave@...1.net>
To:	dave@...1.net
Cc:	dave.hansen@...ux.intel.com, john@...nmccutchan.com,
	rlove@...ve.org, eparis@...isplace.org, viro@...iv.linux.org.uk,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fs: inotify: systemd needs it so make it depend on CONFIG_EMBEDDED


From: Dave Hansen <dave.hansen@...ux.intel.com>

I have a little microbenchmark that sits and does write() in a loop.
The number one kernel function in the profiles is __srcu_read_lock()
from fsnotify().  I decided to turn off INOTIFY in order to see what
the potential from optimizing this path would be.  I ended up with
a system at the rescue console as systemd complained that dependencies
were not met mounting some non-root filesystems:

	systemd: inotify_init1() failed: Function not implemented
	systemd: Dependency failed for Mark the need to relabel after reboot.
	systemd: Triggering OnFailure= dependencies of local-fs.target.
	systemd: inotify_init1() failed: Function not implemented
	systemd: Dependency failed for /gcc.

It looks like CONFIG_INOTIFY is now a critical part of any system
that wants to both use systemd and boot.  Let's make it depend
on CONFIG_EMBEDDED.

Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: John McCutchan <john@...nmccutchan.com>
Cc: Robert Love <rlove@...ve.org>
Cc: Eric Paris <eparis@...isplace.org>
Cc: Alexander Viro <viro@...iv.linux.org.uk>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org

---

 b/fs/notify/inotify/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off fs/notify/inotify/Kconfig
--- a/fs/notify/inotify/Kconfig~make-inotify-harder-to-turn-off	2015-06-19 10:54:06.528721072 -0700
+++ b/fs/notify/inotify/Kconfig	2015-06-19 10:55:16.426892530 -0700
@@ -1,5 +1,5 @@
 config INOTIFY_USER
-	bool "Inotify support for userspace"
+	bool "Inotify support for userspace" if EMBEDDED
 	select ANON_INODES
 	select FSNOTIFY
 	default y
_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/