linux-kernel - Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in krb5_rc4_setup_enc/seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150619195251.GD21903@fieldses.org>
Date:	Fri, 19 Jun 2015 15:52:51 -0400
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel@...r.kernel.org,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Anna Schumaker <anna.schumaker@...app.com>,
	"David S. Miller" <davem@...emloft.net>, linux-nfs@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 1/1 net-next] sunrpc: use sg_init_one() in
 krb5_rc4_setup_enc/seq_key()

Thanks, applying.--b.

On Tue, Jun 16, 2015 at 09:57:52PM +0200, Fabian Frederick wrote:
> Don't opencode sg_init_one()
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> index b5408e8..fee3c15 100644
> --- a/net/sunrpc/auth_gss/gss_krb5_crypto.c
> +++ b/net/sunrpc/auth_gss/gss_krb5_crypto.c
> @@ -881,9 +881,7 @@ krb5_rc4_setup_seq_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
>  	if (err)
>  		goto out_err;
>  
> -	sg_init_table(sg, 1);
> -	sg_set_buf(sg, &zeroconstant, 4);
> -
> +	sg_init_one(sg, &zeroconstant, 4);
>  	err = crypto_hash_digest(&desc, sg, 4, Kseq);
>  	if (err)
>  		goto out_err;
> @@ -951,9 +949,7 @@ krb5_rc4_setup_enc_key(struct krb5_ctx *kctx, struct crypto_blkcipher *cipher,
>  	if (err)
>  		goto out_err;
>  
> -	sg_init_table(sg, 1);
> -	sg_set_buf(sg, zeroconstant, 4);
> -
> +	sg_init_one(sg, zeroconstant, 4);
>  	err = crypto_hash_digest(&desc, sg, 4, Kcrypt);
>  	if (err)
>  		goto out_err;
> -- 
> 2.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/