linux-kernel - Re: [PATCH] staging: comedi: fix sparse warning in comedi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <cover.1434808718.git.geliangtang@163.com>
Date:	Sat, 20 Jun 2015 22:38:58 +0800
From:	Geliang Tang <geliangtang@....com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Geliang Tang <geliangtang@....com>, abbotti@....co.uk,
	hsweeten@...ionengravers.com, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: fix sparse warning in comedi_compat32.c

On Sat, Jun 20, 2015 at 04:08:19PM +0530, Sudip Mukherjee wrote:
> compat_ptr is already a typecast.
> static inline void __user *compat_ptr(compat_uptr_t uptr)
> {
>       return (void __user *)(unsigned long)uptr;
> }
> 
> so you are adding another typecast to an already exitsing typecast. :(
> 
> and besides, this also introduces one new checkpatch warning of
> line more than 80 char.
> 
> regards
> sudip

Thank you for your review. I revised the patch as you suggested. Here it is.

Geliang Tang (1):
  staging: comedi: fix cast warning in comedi_compat32.c

 drivers/staging/comedi/comedi_compat32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.3.4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/