linux-kernel - Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C825257E-3CD1-4037-BC23-12D48F680EF9@holtmann.org>
Date:	Sat, 20 Jun 2015 23:58:11 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Xi Ruoyao <xry111@...look.com>
Cc:	"Gustavo F. Padovan" <gustavo@...ovan.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
	Daniel Drake <drake@...lessm.com>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH] Bluetooth: btusb: Add Realtek devices into module device table

Hi Xi,

> In 'commit a2698a9bf9b0 ("Bluetooth: btusb: Add Realtek
> 8723A/8723B/8761A/8821A support"), support of some Realtek
> devices was added to the Generic Bluetooth USB driver in kernel.
> However, these devices are not in the module device table of 
> btusb.ko, so the kernel wouldn't probe them at all.
> 
> To fix this, add four entries in the device table btusb_table,
> based on code from <https://github.com/lwfinger/rtl8723au_bt>
> ('new' branch).
> 
> This enables bluetooth support in the Lenovo Ideapad Yoga 13
> which has RTL8723AU USB device, with product ID 0bda:1724.
> 
> Signed-off-by: Xi Ruoyao <xry111@...look.com>
> ---
> drivers/bluetooth/btusb.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 3c10d4d..dd87623 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -148,6 +148,12 @@ static const struct usb_device_id btusb_table[] = {
> 	{ USB_DEVICE(0x8087, 0x0a5a),
> 	  .driver_info = BTUSB_INTEL_BOOT | BTUSB_BROKEN_ISOC },
> 
> +	/* Realtek Bluetooth  */
> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x0bda, 0xe0, 0x01, 0x01) },
> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x0bd5, 0xe0, 0x01, 0x01) },
> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x13d3, 0xe0, 0x01, 0x01) },
> +	{ USB_VENDOR_AND_INTERFACE_INFO(0x0489, 0xe0, 0x01, 0x01) },
> +

I highly doubt these are needed. There is a generic entry for an USB transport that is already covering these.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/