linux-kernel - Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on previous lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150620072402.GA15195@sudip-PC>
Date:	Sat, 20 Jun 2015 12:54:02 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Isaac Assegai <isaac.a.travers@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-fbdev@...r.kernel.org, gregkh@...uxfoundation.org,
	teddy.wang@...iconmotion.com
Subject: Re: [PATCH 6/8] Staging: sm750fb: ddk750_sii164.c: Place braces on
 previous lines

On Fri, Jun 19, 2015 at 12:48:19PM -0700, Isaac Assegai wrote:
> Place braces on previous lines in ddk750_sii164.c to
> rectify the following checkpatch errors:
> ERROR: that open brace { should be on the previous line
> 
> Signed-off-by: Isaac Assegai <isaac.a.travers@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_sii164.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
> index 7f58fbe..64d4291 100644
> --- a/drivers/staging/sm750fb/ddk750_sii164.c
> +++ b/drivers/staging/sm750fb/ddk750_sii164.c
> @@ -136,8 +136,7 @@ long sii164InitChip(
>  #endif
>  
>  	/* Check if SII164 Chip exists */
> -	if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID))
> -	{
> +	if ((sii164GetVendorID() == SII164_VENDOR_ID) && (sii164GetDeviceID() == SII164_DEVICE_ID) {
												^^^^
you have not build tested it :(
In function ‘sii164InitChip’:
error: expected ‘)’ before ‘{’ token

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/