linux-kernel - Re: [PATCH v3] staging: sm750fb: use tabs for indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 20 Jun 2015 13:13:35 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Juston Li <juston.h.li@...il.com>
Cc:	teddy.wang@...iconmotion.com, gregkh@...uxfoundation.org,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: sm750fb: use tabs for indentation

On Fri, Jun 19, 2015 at 10:50:57PM -0700, Juston Li wrote:
> Replace spaces with tabs for indentation to fix the checkpatch.pl warning
> 'WARNING: please, no spaces at the start of a line'
> 
> checkpatch doesn't catch comments indented by spaces but I fixed comments
> adjacent to warnings as well so they would remain aligned.
> 
> Signed-off-by: Juston Li <juston.h.li@...il.com>
> ---
<snip>
> diff --git a/drivers/staging/sm750fb/ddk750_hwi2c.c b/drivers/staging/sm750fb/ddk750_hwi2c.c
> index 7826376..23d6e19 100644
> --- a/drivers/staging/sm750fb/ddk750_hwi2c.c
> +++ b/drivers/staging/sm750fb/ddk750_hwi2c.c
> @@ -9,71 +9,69 @@
>  #define HWI2C_WAIT_TIMEOUT              0xF0000
>  
>  
> -int hwI2CInit(
> -    unsigned char busSpeedMode
> -)
> +int hwI2CInit(unsigned char busSpeedMode)
but this is what you say in commit message. Please only do one type of
change in a single patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/