linux-kernel - Re: [PATCH] aoe: Convert use of __constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5584B79F.9080004@acm.org>
Date:	Fri, 19 Jun 2015 20:45:19 -0400
From:	Ed Cashin <ed.cashin@....org>
To:	Vaishali Thakkar <vthakkar1994@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aoe: Convert use of __constant_htons to htons

OK.  Thanks.

On 06/18/2015 11:23 PM, Vaishali Thakkar wrote:
> In little endian cases, the macro htons unfolds to __swab16 which
> provides special case for constants. In big endian cases,
> __constant_htons and htons expand directly to the same expression.
> So, replace __constant_htons with htons with the goal of getting
> rid of the definition of __constant_htons completely.
>
> The semantic patch that performs this transformation is as follows:
>
> @@expression x;@@
>
> - __constant_htons(x)
> + htons(x)
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@...il.com>
> ---
>   drivers/block/aoe/aoenet.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
> index 63773a9..78ff47a 100644
> --- a/drivers/block/aoe/aoenet.c
> +++ b/drivers/block/aoe/aoenet.c
> @@ -192,7 +192,7 @@ exit:
>   }
>   
>   static struct packet_type aoe_pt __read_mostly = {
> -	.type = __constant_htons(ETH_P_AOE),
> +	.type = htons(ETH_P_AOE),
>   	.func = aoenet_rcv,
>   };
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/