linux-kernel - [tip:x86/apic] x86/hpet: Check for irq== 0 when allocating hpet MSI interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-bafac298fb20e9ae1305c710d4fd8d20c5911afa@git.kernel.org>
Date:	Sat, 20 Jun 2015 03:07:55 -0700
From:	tip-bot for Jiang Liu <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, bp@...en8.de,
	tglx@...utronix.de, mingo@...nel.org, sergey.senozhatsky@...il.com,
	jiang.liu@...ux.intel.com
Subject: [tip:x86/apic] x86/hpet: Check for irq==
 0 when allocating hpet MSI interrupts

Commit-ID:  bafac298fb20e9ae1305c710d4fd8d20c5911afa
Gitweb:     http://git.kernel.org/tip/bafac298fb20e9ae1305c710d4fd8d20c5911afa
Author:     Jiang Liu <jiang.liu@...ux.intel.com>
AuthorDate: Sat, 20 Jun 2015 11:50:50 +0200
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sat, 20 Jun 2015 12:00:58 +0200

x86/hpet: Check for irq==0 when allocating hpet MSI interrupts

irq == 0 is not a valid irq for a irqdomain MSI allocation, but hpet
code checks only for negative return values.

Reported-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc: Borislav Petkov <bp@...en8.de>
Link: http://lkml.kernel.org/r/558447AF.30703@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
---
 arch/x86/kernel/hpet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index e2449cf..c47aab3 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -578,7 +578,7 @@ static void hpet_msi_capability_lookup(unsigned int start_timer)
 			continue;
 
 		irq = hpet_assign_irq(hpet_domain, hdev, hdev->num);
-		if (irq < 0)
+		if (irq <= 0)
 			continue;
 
 		sprintf(hdev->name, "hpet%d", i);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/