linux-kernel - Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55855F49.8080407@mev.co.uk>
Date:	Sat, 20 Jun 2015 13:40:41 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	"Abdul, Hussain (H.)" <habdul@...teon.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"hsweeten@...ionengravers.com" <hsweeten@...ionengravers.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/6] Staging: comedi: Simplify a trivial if-return sequence

On 19/06/15 06:59, Abdul, Hussain (H.) wrote:
>
>
> This patch simplify a trivial if-return sequence. Possibly combine with
> a preceding function call.
>
> Abdul Hussain (6):
>      staging: comedi: dmm32at: Simplify a trivial if-return sequence
>      staging: comedi: fl512: Simplify a trivial if-return sequence
>      staging: comedi: daqboard2000: Simplify a trivial if-return sequence
>      staging: comedi: dac02: Simplify a trivial if-return sequence
>      staging: comedi: daq_dio24: Simplify a trivial if-return sequence
>      staging: comedi: s626: Simplify a trivial if-return sequence
>
>
> drivers/staging/comedi/drivers/dac02.c        | 6 +-----
> drivers/staging/comedi/drivers/daqboard2000.c | 7 +------
> drivers/staging/comedi/drivers/dmm32at.c      | 6 +-----
> drivers/staging/comedi/drivers/fl512.c        | 6 +-----
> drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-----
> drivers/staging/comedi/drivers/s626.c         | 6 +-----


Looks good apart from the checkpatch warning in patch 3 as pointed out 
by Sudip.

For patches 1-2 and 4-6:
Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/