linux-kernel - Re: [PATCH 03/15] nd_btt: atomic sector updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4iA96Khapnm54JZkgiduoqyWo1x45r7EX=OU8cs1dyhsw@mail.gmail.com>
Date:	Sun, 21 Jun 2015 09:31:02 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Jens Axboe <axboe@...nel.dk>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	Boaz Harrosh <boaz@...xistor.com>,
	"Kani, Toshimitsu" <toshi.kani@...com>,
	Vishal Verma <vishal.l.verma@...ux.intel.com>,
	Neil Brown <neilb@...e.de>,
	Greg KH <gregkh@...uxfoundation.org>,
	Dave Chinner <david@...morbit.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...capital.net>,
	Jens Axboe <axboe@...com>,
	Linux ACPI <linux-acpi@...r.kernel.org>,
	Jeff Moyer <jmoyer@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 03/15] nd_btt: atomic sector updates

On Sun, Jun 21, 2015 at 3:03 AM, Christoph Hellwig <hch@....de> wrote:
>> +config ND_MAX_REGIONS
>> +     int "Maximum number of regions supported by the sub-system"
>> +     default 64
>> +     ---help---
>> +       A 'region' corresponds to an individual DIMM or an interleave
>> +       set of DIMMs.  A typical maximally configured system may have
>> +       up to 32 DIMMs.
>> +
>> +       Leave the default of 64 if you are unsure.
>
> Having static limits in Kconfig is a bad idea.  What prevents you
> from handling any (reasonable) number dynamically?

Hmm, yes, this was a bad holdover from before we were using percpu
definitions for the lane locks.  Now that it's converted we can kill
the static definition of nd_percpu_lane and just do an alloc_percpu()
for each region dynamically.  Fixed in v2 and passing the test suite.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/