linux-kernel - Re: [PATCH] mfd: fix dependency warning for CHROME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5586027E.50304@collabora.co.uk>
Date:	Sun, 21 Jun 2015 02:17:02 +0200
From:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org
CC:	Lee Jones <lee.jones@...aro.org>, Heiko Stuebner <heiko@...ech.de>,
	Olof Johansson <olof@...om.net>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd: fix dependency warning for CHROME_PLATFORMS on !X86,
 !ARM

Hello Paul,

On 06/21/2015 02:01 AM, Paul Gortmaker wrote:
> In commit 062476f24aa7cf714169342cc50626fd9bbb93da ("mfd: cros_ec:
> Move protocol helpers out of the MFD driver") there was a select
> added on CHROME_PLATFORMS, which leads to the following for ppc/mips:
> 
> warning: (MFD_CROS_EC) selects CHROME_PLATFORMS which has unmet
> direct dependencies (X86 || ARM)
>

Right, sorry for missing that and thank a lot for taking care of it.
 
> Presumably the above means MFD_CROS_EC is only currently useful
> on x86 and ARM, so lets limit it to there.
>

That is correct, although I wonder if CHROME_PLATFORMS should not
also depend on || COMPILE_TEST and same for MFD_CROS_EC so those
have at least build coverage on other architectures.

I can't think for a reason to not be buildable on other archs...

> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: Olof Johansson <olof@...om.net>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/mfd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 653815950aa2..d3235e6f1953 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -94,6 +94,7 @@ config MFD_AXP20X
>  
>  config MFD_CROS_EC
>  	tristate "ChromeOS Embedded Controller"
> +	depends on X86 || ARM
>  	select MFD_CORE
>  	select CHROME_PLATFORMS
>  	select CROS_EC_PROTO
> 

...but that is orthogonal to this patch so:

Acked-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/