linux-kernel - Re: [PATCH 10/15] libnvdimm: fix up max_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4gtFeFt-Mpa=s9bs+W+4LpHP4cTCFu6To5FG0Z1_uOEkA@mail.gmail.com>
Date:	Sun, 21 Jun 2015 06:28:43 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Jens Axboe <axboe@...nel.dk>,
	"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
	Boaz Harrosh <boaz@...xistor.com>,
	"Kani, Toshimitsu" <toshi.kani@...com>,
	Vishal Verma <vishal.l.verma@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux ACPI <linux-acpi@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 10/15] libnvdimm: fix up max_hw_sectors

On Sun, Jun 21, 2015 at 3:08 AM, Christoph Hellwig <hch@....de> wrote:
>> +void nd_blk_queue_init(struct request_queue *q)
>> +{
>> +     blk_queue_max_hw_sectors(q, UINT_MAX);
>> +     blk_queue_bounce_limit(q, BLK_BOUNCE_ANY);
>> +}
>
> Please just add the calls to the drivers instead of this helper which
> hides the intent.

I thought it made it clearer what properties are shared between block
devices on an nvdimm bus, but if you're initial reaction is that it
hides intent I'll kill the helper.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/