linux-kernel - Re: [PATCH 1/2] iio: ABI: Clarify proximity output value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5586BE75.8090602@kernel.org>
Date:	Sun, 21 Jun 2015 14:39:01 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Peter Meerwald <pmeerw@...erw.net>,
	Daniel Baluta <daniel.baluta@...el.com>
CC:	vlad.dogaru@...el.com, tiberiu.a.breana@...el.com, knaack.h@....de,
	lars@...afoo.de, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: ABI: Clarify proximity output value

On 16/06/15 21:41, Peter Meerwald wrote:
> Hello,
> 
>> Current description for proximity measurement is ambiguous. While
>> the first part says that proximity is measured by observing
>> reflectivity, the second part incorrectly infers that reported values
>> should behave like a distance.
>>
>> This is because of AS3935 lightning sensor which uses the proximity
>> API, while not being a true proximity sensor.
> 
> Acked-by: Peter Meerwald <pmeerw@...erw.net>
Thanks Peter, this will stand for the record on the mailing list, but
now the patch is in a public (non testing tree) I'm not going to rebase
to add it to the patch.

Sorry about that, but 3 days too late :(

Jonathan
>  
>> Fixes:  614e8842ddf ("iio: ABI: add clarification for proximity")
>> Signed-off-by: Daniel Baluta <daniel.baluta@...el.com>
>> ---
>>  Documentation/ABI/testing/sysfs-bus-iio | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index bbed111..70c9b1a 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1234,10 +1234,8 @@ Description:
>>  		object is near the sensor, usually be observing
> 
>>  		reflectivity of infrared or ultrasound emitted.
>>  		Often these sensors are unit less and as such conversion
>> -		to SI units is not possible.  Where it is, the units should
>> -		be meters.  If such a conversion is not possible, the reported
>> -		values should behave in the same way as a distance, i.e. lower
>> -		values indicate something is closer to the sensor.
>> +		to SI units is not possible. Higher proximity measurements
>> +		indicate closer objects, and vice versa.
>>  
>>  What:		/sys/.../iio:deviceX/in_illuminance_input
>>  What:		/sys/.../iio:deviceX/in_illuminance_raw
>>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/