linux-kernel - Re: [PATCH] gpio: Add AMD SB8XX/SB9XX/A5X/A8X driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434962926.19497.88.camel@x220>
Date:	Mon, 22 Jun 2015 10:48:46 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Tobias Diedrich <ranma+kernel@...edrich.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: Add AMD SB8XX/SB9XX/A5X/A8X driver

[Shouldn't gpio patches be sent to Linus Walleij, Alexandre Courbot, and
the linux-gpio list too?]

Just a nit: a license mismatch.

On Sat, 2015-06-20 at 23:57 +0200, Tobias Diedrich wrote:
> --- /dev/null
> +++ b/drivers/gpio/gpio-sb8xx.c

> + * This file is licensed under  the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.

This states the license is GPL v2.

> +MODULE_LICENSE("GPL");

And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think that either the comment at the top of this file
or the ident used in the MODULE_LICENSE() macro needs to change.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/