linux-kernel - Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before the open parenthesis '('" errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Jun 2015 16:40:14 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Greg Donald <gdonald@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Aya Mahfouz <mahfouz.saif.elyazal@...il.com>,
	Haneen Mohammed <hamohammed.sa@...il.com>,
	Cristina Opriceana <cristina.opriceana@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: rtl8192u: Fix "space required before
 the open parenthesis '('" errors

On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
> Fix checkpatch.pl "space required before the open parenthesis '('" errors
> 
> Signed-off-by: Greg Donald <gdonald@...il.com>
> ---
>  .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c    | 97 ++++++++++------------
>  1 file changed, 44 insertions(+), 53 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index c2588f8..df20979 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
<snip>
> @@ -127,8 +127,7 @@ void HTDebugHTCapability(u8 *CapIE, u8 *TitleString )
>  	static u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};	// For 11n EWC definition, 2007.07.17, by Emily
>  	PHT_CAPABILITY_ELE		pCapELE;
>  
> -	if(!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap)))
> -	{
> +	if (!memcmp(CapIE, EWC11NHTCap, sizeof(EWC11NHTCap))) {
							  ^^^^^^^
this becomes a different kind of change than what is mentioned in your
commit message.
You are also adding space after ',' later in your patch.
please do only one kind of change in one patch.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/