| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150622125524.GA26143@xo-6d-61-c0.localdomain>
Date: Mon, 22 Jun 2015 14:55:24 +0200
From: Pavel Machek <pavel@....cz>
To: Anda-Maria Nicolae <anda-maria.nicolae@...el.com>
Cc: sre@...nel.org, dbaryshkov@...il.com, robh+dt@...nel.org,
pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
dwmw2@...radead.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] power_supply: bq2415x_charger: Fix coding style
issues
On Tue 2015-05-12 12:11:32, Anda-Maria Nicolae wrote:
> This patch fixes the following issues reported by checkpatch.pl:
> - use -EINVAL instead of -ENOSYS, to fix warning message:
> "ENOSYS means 'invalid syscall nr' and nothing else"
So you change the ABI? Just like that? With changelog saying "cleanup checkpatch"?
Maybe it is ok to change the ABI... but you should say so clearly in the changelog...
Pavel
> diff --git a/drivers/power/bq2415x_charger.c b/drivers/power/bq2415x_charger.c
> index 6c534dc..2cf8ec7 100644
> --- a/drivers/power/bq2415x_charger.c
> +++ b/drivers/power/bq2415x_charger.c
> @@ -631,7 +631,7 @@ static int bq2415x_set_charge_current(struct bq2415x_device *bq, int mA)
> int val;
>
> if (bq->init_data.resistor_sense <= 0)
> - return -ENOSYS;
> + return -EINVAL;
>
> val = (mA * bq->init_data.resistor_sense - 37400) / 6800;
> if (val < 0)
> @@ -650,7 +650,7 @@ static int bq2415x_get_charge_current(struct bq2415x_device *bq)
> int ret;
>
> if (bq->init_data.resistor_sense <= 0)
> - return -ENOSYS;
> + return -EINVAL;
>
> ret = bq2415x_i2c_read_mask(bq, BQ2415X_REG_CURRENT,
> BQ2415X_MASK_VI_CHRG, BQ2415X_SHIFT_VI_CHRG);
> @@ -665,7 +665,7 @@ static int bq2415x_set_termination_current(struct bq2415x_device *bq, int mA)
> int val;
>
> if (bq->init_data.resistor_sense <= 0)
> - return -ENOSYS;
> + return -EINVAL;
>
> val = (mA * bq->init_data.resistor_sense - 3400) / 3400;
> if (val < 0)
> @@ -684,7 +684,7 @@ static int bq2415x_get_termination_current(struct bq2415x_device *bq)
> int ret;
>
> if (bq->init_data.resistor_sense <= 0)
> - return -ENOSYS;
> + return -EINVAL;
>
> ret = bq2415x_i2c_read_mask(bq, BQ2415X_REG_CURRENT,
> BQ2415X_MASK_VI_TERM, BQ2415X_SHIFT_VI_TERM);
> @@ -1166,7 +1166,7 @@ static ssize_t bq2415x_sysfs_set_mode(struct device *dev,
>
> if (strncmp(buf, "auto", 4) == 0) {
> if (bq->automode < 0)
> - return -ENOSYS;
> + return -EINVAL;
> bq->automode = 1;
> mode = bq->reported_mode;
> } else if (strncmp(buf, "off", 3) == 0) {
> @@ -1556,28 +1556,28 @@ static int bq2415x_probe(struct i2c_client *client,
>
> bq = devm_kzalloc(&client->dev, sizeof(*bq), GFP_KERNEL);
> if (!bq) {
> - dev_err(&client->dev, "failed to allocate device data\n");
> ret = -ENOMEM;
> goto error_2;
> }
>
> if (np) {
> - bq->notify_psy = power_supply_get_by_phandle(np, "ti,usb-charger-detection");
> + bq->notify_psy = power_supply_get_by_phandle(np,
> + "ti,usb-charger-detection");
>
> if (IS_ERR(bq->notify_psy)) {
> dev_info(&client->dev,
> - "no 'ti,usb-charger-detection' property (err=%ld)\n",
> + "no 'ti,usb-charger-detection' property (err=%ld)\n",
> PTR_ERR(bq->notify_psy));
> bq->notify_psy = NULL;
> } else if (!bq->notify_psy) {
> ret = -EPROBE_DEFER;
> goto error_2;
> }
> - }
> - else if (pdata->notify_device)
> + } else if (pdata->notify_device) {
> bq->notify_psy = power_supply_get_by_name(pdata->notify_device);
> - else
> + } else {
> bq->notify_psy = NULL;
> + }
>
> i2c_set_clientdata(client, bq);
>
> @@ -1592,11 +1592,11 @@ static int bq2415x_probe(struct i2c_client *client,
>
> if (np) {
> ret = of_property_read_u32(np, "ti,current-limit",
> - &bq->init_data.current_limit);
> + &bq->init_data.current_limit);
> if (ret)
> goto error_3;
> ret = of_property_read_u32(np, "ti,weak-battery-voltage",
> - &bq->init_data.weak_battery_voltage);
> + &bq->init_data.weak_battery_voltage);
> if (ret)
> goto error_3;
> ret = of_property_read_u32(np, "ti,battery-regulation-voltage",
> @@ -1604,15 +1604,15 @@ static int bq2415x_probe(struct i2c_client *client,
> if (ret)
> goto error_3;
> ret = of_property_read_u32(np, "ti,charge-current",
> - &bq->init_data.charge_current);
> + &bq->init_data.charge_current);
> if (ret)
> goto error_3;
> ret = of_property_read_u32(np, "ti,termination-current",
> - &bq->init_data.termination_current);
> + &bq->init_data.termination_current);
> if (ret)
> goto error_3;
> ret = of_property_read_u32(np, "ti,resistor-sense",
> - &bq->init_data.resistor_sense);
> + &bq->init_data.resistor_sense);
> if (ret)
> goto error_3;
> } else {
> @@ -1648,7 +1648,8 @@ static int bq2415x_probe(struct i2c_client *client,
> }
>
> /* Query for initial reported_mode and set it */
> - bq2415x_notifier_call(&bq->nb, PSY_EVENT_PROP_CHANGED, bq->notify_psy);
> + bq2415x_notifier_call(&bq->nb, PSY_EVENT_PROP_CHANGED,
> + bq->notify_psy);
> bq2415x_set_mode(bq, bq->reported_mode);
>
> bq->automode = 1;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists