linux-kernel - Re: [PATCH v2 1/2] staging: comedi: no space before tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150622131209.GA25517@goodgumbo.baconseed.org>
Date:	Mon, 22 Jun 2015 15:12:09 +0200
From:	Luis de Bethencourt <luis@...ethencourt.com>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	linux-kernel@...r.kernel.org,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jaime Arrocha <jarr@...neldev.net>
Subject: Re: [PATCH v2 1/2] staging: comedi: no space before tabs

On Mon, Jun 22, 2015 at 01:40:07PM +0100, Ian Abbott wrote:
> On 22/06/15 13:31, Luis de Bethencourt wrote:
> >Warning found by checkpatch.pl
> >WARNING: please, no space before tabs
> >/drivers/staging/comedi/drivers/das16m1.c:83
> >+  404-407 ^I8254$
> >
> >Signed-off-by: Luis de Bethencourt <luis@...ethencourt.com>
> >---
> >  drivers/staging/comedi/drivers/das16m1.c | 24 ++++++++++++------------
> >  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> Like for your "Author string" patch for das08_cs.c, it would be nice
> to mention the module name in the subject line in this patch and in
> patch 2 of the series, especially as these changes are for a
> specific module, not the whole of comedi.
> 

Makes sense. I should've gone ahead and done it sooner. Fixed now.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/