linux-kernel - Re: [PATCH 4.0 050/105] i2c: hix5hd2: Fix modalias to make module auto-loading work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1434982982.2524.10.camel@tiscali.nl>
Date:	Mon, 22 Jun 2015 16:23:02 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Cc:	stable@...r.kernel.org, Axel Lin <axel.lin@...ics.com>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>
Subject: Re: [PATCH 4.0 050/105] i2c: hix5hd2: Fix modalias to make module
 auto-loading work

On Fri, 2015-06-19 at 13:35 -0700, Greg Kroah-Hartman wrote:
> Make the modalias match driver name, this is required to make module
> auto-loading work.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> Acked-by: Zhangfei Gao <zhangfei.gao@...aro.org>
> Signed-off-by: Wolfram Sang <wsa@...-dreams.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  drivers/i2c/busses/i2c-hix5hd2.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/i2c/busses/i2c-hix5hd2.c
> +++ b/drivers/i2c/busses/i2c-hix5hd2.c
> @@ -554,4 +554,4 @@ module_platform_driver(hix5hd2_i2c_drive
>  MODULE_DESCRIPTION("Hix5hd2 I2C Bus driver");
>  MODULE_AUTHOR("Wei Yan <sledge.yanwei@...wei.com>");
>  MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:i2c-hix5hd2");
> +MODULE_ALIAS("platform:hix5hd2-i2c");

How does this work?

My current understanding is that for module auto-loading to work with
the platform: prefix one needs a matching platform_device (ie, a struct
platform_device with .name being "hix5hd2-i2c"). And I couldn't spot
where that platform_device is created in 4.0 or v4.1.

Does matching platform_driver.driver.name (which is what this patch
appears to do) also enable module auto-loading? That would mean there's
another, even less obvious, mechanism at work here.

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/