linux-kernel - Re: [PATCH 1/3] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55884831.6080409@cogentembedded.com>
Date:	Mon, 22 Jun 2015 20:38:57 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Phil Edworthy <phil.edworthy@...esas.com>,
	Kishon Vijay Abraham I <kishon@...com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
	Simon Horman <horms@...ge.net.au>
CC:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH 1/3] usb: renesas_usbhs: Allow an OTG PHY driver to provide
 VBUS

Hello.

On 06/22/2015 05:42 PM, Phil Edworthy wrote:

> These changes allow a PHY driver to trigger a VBUS interrupt and
> to provide the value of VBUS.

> Signed-off-by: Phil Edworthy <phil.edworthy@...esas.com>
> ---
>   drivers/usb/renesas_usbhs/common.h     |  2 ++
>   drivers/usb/renesas_usbhs/mod.c        |  3 +++
>   drivers/usb/renesas_usbhs/mod_gadget.c | 38 ++++++++++++++++++++++++++++++++++
>   3 files changed, 43 insertions(+)

> diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
> index 8c5fc12..94a7aeb 100644
> --- a/drivers/usb/renesas_usbhs/common.h
> +++ b/drivers/usb/renesas_usbhs/common.h
> @@ -255,6 +255,8 @@ struct usbhs_priv {
>   	struct renesas_usbhs_driver_param	dparam;
>
>   	struct delayed_work notify_hotplug_work;
> +	int vbus_is_indirect;

    s/int/bool/.

> +	int vbus_indirect_value;

    Likewise.

>   	struct platform_device *pdev;
>
>   	struct extcon_dev *edev;
[...]
> diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c
> index dc2aa32..2cfdb50 100644
> --- a/drivers/usb/renesas_usbhs/mod_gadget.c
> +++ b/drivers/usb/renesas_usbhs/mod_gadget.c
[...]
> @@ -891,6 +895,17 @@ static int usbhsg_gadget_start(struct usb_gadget *gadget,
>   	/* first hook up the driver ... */
>   	gpriv->driver = driver;
>
> +	/* connect to bus through transceiver */
> +	if (!IS_ERR_OR_NULL(gpriv->transceiver)) {
> +		ret = otg_set_peripheral(gpriv->transceiver->otg,
> +					&gpriv->gadget);
> +		if (ret) {
> +			dev_info(dev, "%s: can't bind to transceiver\n",

    dev_err().

[...]
> @@ -994,6 +1028,10 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv)
>   		goto usbhs_mod_gadget_probe_err_gpriv;
>   	}
>
> +	gpriv->transceiver = usb_get_phy(USB_PHY_TYPE_UNDEFINED);
> +	dev_info(dev, "%s transceiver found\n",
> +		 gpriv->transceiver ? "" : "No");

	dev_info(dev, "%stransceiver found\n",
		 gpriv->transceiver ? "" : "no ");

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/