linux-kernel - Re: [PATCH] staging: sm750fb: use tabs for indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFow2F_AKeKc54EZu0QE5ovPkyuZ2bem9BUC1d-vf23k3p6exQ@mail.gmail.com>
Date:	Mon, 22 Jun 2015 11:30:30 -0700
From:	Juston Li <juston.h.li@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	teddy.wang@...iconmotion.com, Greg KH <gregkh@...uxfoundation.org>,
	linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: use tabs for indentation

On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:
> On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote:
>>  void sii164ClearInterrupt(void)
>>  {
>> -    unsigned char detectReg;
>> +     unsigned char detectReg;
>>
>> -    /* Clear the MDI interrupt */
>> -    detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
>> -    i2cWriteReg(SII164_I2C_ADDRESS, SII164_DETECT, detectReg | SII164_DETECT_MONITOR_STATE_CLEAR);
>
> The patch accidentally deletes this write.
>
>> +     /* Clear the MDI interrupt */
>> +     detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
>>  }
>
> regards,
> dan carpenter

This was fixed and patch is now included in the patchset:
[PATCH v2 00/19] staging: sm750fb: checkpatch.pl fixes

Regards
Juston
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/