linux-kernel - Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial if-return sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55887278.3010705@mailbox.org>
Date:	Mon, 22 Jun 2015 22:39:20 +0200
From:	Markus Böhme <markus.boehme@...lbox.org>
To:	"Abdul, Hussain (H.)" <habdul@...teon.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"abbotti@....co.uk" <abbotti@....co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/6] Staging: combine: daqboard2000: Simplify a trivial
 if-return sequence

> --- a/drivers/staging/comedi/drivers/daqboard2000.c
> +++ b/drivers/staging/comedi/drivers/daqboard2000.c
> @@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device *dev,
>   		return result;
>
>   	s = &dev->subdevices[2];
> -	result = subdev_8255_init(dev, s, daqboard2000_8255_cb,
> -				  dioP2ExpansionIO8Bit);
> -	if (result)
> -		return result;
> -
> -	return 0;
> +	return subdev_8255_init(dev, s, daqboard2000_8255_cb,
> +			dioP2ExpansionIO8Bit);
>   }

What do you think about horizontally aligning the parameters in the second line?
They were previously.

Regards,
Markus


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/