linux-kernel - Re: [PATCH] staging: ft1000: convert pack pragma to __packed_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1435009704.9808.32.camel@perches.com>
Date:	Mon, 22 Jun 2015 14:48:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>
Cc:	gregkh@...uxfoundation.org, marek.belisko@...il.com,
	tapaswenipathak@...il.com, mahfouz.saif.elyazal@...il.com,
	tinajohnson.1234@...il.com, gulsah.1004@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ft1000: convert pack pragma to __packed__
 attribute

On Mon, 2015-06-22 at 22:12 +0300, Giedrius Statkevičius wrote:
> Convert a Microsoft compiler specific directive "#pragma pack(1)" to a
> GCC equivalent __attribute__ ((__packed__)). Also, by doing this we save
> ourselves from trouble if any other struct definitions are added after
> the #pragma because it will be applied to all of the definitions
> following it.
[]
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c b/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
[]
> @@ -95,7 +95,6 @@ struct dsp_file_hdr {
>  	long              nDspImages;          /* Number of DSP images in file. */
>  };
>  
> -#pragma pack(1)
>  struct dsp_image_info {
>  	long              coff_date;           /* Date/time when DSP Coff image was built. */
>  	long              begin_offset;        /* Offset in file where image begins. */
> @@ -105,7 +104,7 @@ struct dsp_image_info {
>  	long              version;             /* Embedded version # of DSP code. */
>  	unsigned short    checksum;            /* DSP File checksum */
>  	unsigned short    pad1;
> -};
> +} __attribute__ ((__packed__));

__packed


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/