linux-kernel - Re: [RFC PATCH v2] packet: remove handling of tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <1504484104.41691434955982414.JavaMail.weblogic@ep2mlwas07a>
Date:	Mon, 22 Jun 2015 06:53:07 +0000 (GMT)
From:	Maninder Singh <maninder1.s@...sung.com>
To:	Frans Klaver <fransklaver@...il.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	Willem de Bruijn <willemb@...gle.com>,
	"dborkman@...hat.com" <dborkman@...hat.com>,
	Alexander Drozdov <al.drozdov@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Eyal Birger <eyal.birger@...il.com>,
	"mst@...hat.com" <mst@...hat.com>, netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [RFC PATCH v2] packet: remove handling of tx_ring

Hi Frans,

>> v1 = replace if()/BUG with BUG_ON() for tx_ring.
>>
>> v2 =
>
>I would keep this below the ---. There's little historical use for
>this version information when it gets merged.
>
>> remove handling of tx_ring in prb_setup_retire_blk_timer
>> for TPACKET_V3 because init_prb_bdqc is called only for NULL tx_ring
>> and thus prb_setup_retire_blk_timer for NULL tx_ring only.
>
>I'd say tx_ring is false, rather than NULL. It's not a pointer (here).
>
>
>> And also in funciton init_prb_bdqc there is no usage of tx_ring.
>
>s,funciton,function,

Thanks for feedback , please check below changelog if it looks ok,
Then i will share updated patch:-

v1 = replace if()/BUG with BUG_ON() for tx_ring.

Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
Signed-off-by: Frans Klaver <fransklaver@...il.com>
---
Changes in v2:

 Remove handling of tx_ring in prb_setup_retire_blk_timer
 for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring 
 and thus prb_setup_retire_blk_timer for zero tx_ring only.

 And also in functon init_prb_bdqc there is no usage of tx_ring.
 Thus removing tx_ring from init_prb_bdqc.

 net/packet/af_packet.c |   14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)
 
 Thanks
 Maninder