linux-kernel - Re: [BUG] ohci_enable() fails during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55891111.50809@ladisch.de>
Date:	Tue, 23 Jun 2015 09:56:01 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Lukasz Stelmach <stlman@...zta.fm>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux1394-devel@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [BUG] ohci_enable() fails during resume

Lukasz Stelmach wrote:
> A bit, suddenly by desktop PC started to fail to resume. [...]
> The failing code is somewhere around line 2400 of
> drivers/firewire/ohci.c (the latest mainline).

>    0x000000000000003f <+31>: callq  0xffffffffffffb037 <copy_config_rom>
>    0x0000000000000044 <+36>: mov    0x898(%rbx),%rax
> -->0x000000000000004b <+43>: mov    (%rax),%edx       <--

(The copy_config_rom call was not actually executed; the else branch
jumped to 44.)

ohci->next_config_rom is NULL because ohci->config_rom is NULL.

> The code around the line 2400 appears to handle multiple
> firewire ports (if I recognise variable names correctly, e.g.
> next_config_rom).

No, this code handles multiple versions of the same data structure.

> Hardware bug in the on-board firewire controller *and* a bug in the
> driver.

Indeed; this appears to be the culprit:
> [  232.855042] firewire_ohci 0000:04:03.0: added OHCI v1.0 device as card 0, 8 IR + 8 IT contexts, quirks 0x0
> [  232.864724] firewire_ohci 0000:04:03.0: bad self ID 0/1 (00000000 != ~00000000)

With the "bad self ID", bus_reset_work() just aborts, and the controller
is never completely initialized (therefore the unexpected NULL).

Try unloading and reloading the firewire-ohci module to see if you can
ever avoid the "bad self ID" error.  But if it stays, your hardware
indeed appears to be broken.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/