linux-kernel - Re: [PATCH] mvneta: add forgotten initialization of autonegotiation bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150623.023351.212943884120317727.davem@davemloft.net>
Date:	Tue, 23 Jun 2015 02:33:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stsp@...t.ru
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	netdev@...r.kernel.org, f.fainelli@...il.com,
	thomas.petazzoni@...e-electrons.com, arno@...isbad.org,
	stsp@...rs.sourceforge.net
Subject: Re: [PATCH] mvneta: add forgotten initialization of
 autonegotiation bits

From: Stas Sergeev <stsp@...t.ru>
Date: Thu, 18 Jun 2015 18:36:03 +0300

> 
> The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state
> signaling")
> changed mvneta_adjust_link() so that it does not clear the auto-negotiation
> bits in MVNETA_GMAC_AUTONEG_CONFIG register. This was necessary for
> auto-negotiation mode to work.
> Unfortunately I haven't checked if these bits are ever initialized.
> It appears they are not.
> This patch adds the missing initialization of the auto-negotiation bits
> in the MVNETA_GMAC_AUTONEG_CONFIG register.
> It fixes the following regression:
> https://www.mail-archive.com/netdev@vger.kernel.org/msg67928.html
> 
> Since the patch was tested to fix a regression, it should be applied to
> stable tree.
> 
> Tested-by: Arnaud Ebalard <arno@...isbad.org>
> 
> CC: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> CC: Florian Fainelli <f.fainelli@...il.com>
> CC: netdev@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: stable@...r.kernel.org
> 
> Signed-off-by: Stas Sergeev <stsp@...rs.sourceforge.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/