linux-kernel - Re: [Xen-devel] [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64AE53A3-12FC-44C0-8AAA-12E99DA3C5A3@oracle.com>
Date:	Tue, 23 Jun 2015 07:57:43 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	david.vrabel@...rix.com, julien.grall@...rix.com,
	marcus.granado@...rix.com, Paul.Durrant@...rix.com,
	Rafal.Mielniczuk@...rix.com, roger.pau@...rix.com,
	xen-devel@...ts.xenproject.org, justing@...ctralogic.com,
	linux-kernel@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH] drivers: xen-blkfront: only talk_to_blkback() when in XenbusStateInitialising

On June 23, 2015 2:23:59 AM EDT, Jan Beulich <JBeulich@...e.com> wrote:
>>>> On 22.06.15 at 15:56, <konrad.wilk@...cle.com> wrote:
>> --- a/drivers/block/xen-blkfront.c
>> +++ b/drivers/block/xen-blkfront.c
>> @@ -1951,6 +1951,8 @@ static void blkback_changed(struct
>xenbus_device *dev,
>>  
>>  	switch (backend_state) {
>>  	case XenbusStateInitWait:
>> +		if (dev->state != XenbusStateInitialising)
>> +			break;
>
>If, as you say in a subsequent reply, all other drivers already have
>such a check, wouldn't it make more sense to put this into xenbus'
>backend_changed() or even xenbus_otherend_changed()?

Good idea. Let me spin an cleanup patch for the race handling  - but put this in the Jens branch as the merge window is happening right now.



>
>Jan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/