lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 23 Jun 2015 14:25:38 +0200 (CEST) From: Julia Lawall <julia.lawall@...6.fr> To: Daniel Granat <d.granat@...sung.com> cc: Julia.Lawall@...6.fr, cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org, Gilles.Muller@...6.fr, nicolas.palix@...g.fr, k.wrona@...sung.com, k.kozlowski@...sung.com Subject: Re: [PATCH v5] Added tables (i2c/platform)_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name. On Tue, 23 Jun 2015, Daniel Granat wrote: > Signed-off-by: Daniel Granat <d.granat@...sung.com> Acked-by: Julia Lawall <julia.lawall@...6.fr> > --- > scripts/coccinelle/misc/of_table.cocci | 33 ++++++++++++++++++++++++++++----- > 1 file changed, 28 insertions(+), 5 deletions(-) > > diff --git a/scripts/coccinelle/misc/of_table.cocci b/scripts/coccinelle/misc/of_table.cocci > index 3c93404..2294915 100644 > --- a/scripts/coccinelle/misc/of_table.cocci > +++ b/scripts/coccinelle/misc/of_table.cocci > @@ -1,6 +1,6 @@ > -/// Make sure of_device_id tables are NULL terminated > +/// Make sure (of/i2c/platform)_device_id tables are NULL terminated > // > -// Keywords: of_table > +// Keywords: of_table i2c_table platform_table > // Confidence: Medium > // Options: --include-headers > > @@ -13,18 +13,26 @@ virtual report > identifier var, arr; > expression E; > @@ > -struct of_device_id arr[] = { > +( > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > ..., > { > .var = E, > * } > }; > +| > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > + ..., > +* { ..., E, ... }, > +}; > +) > > @depends on patch@ > identifier var, arr; > expression E; > @@ > -struct of_device_id arr[] = { > +( > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > ..., > { > .var = E, > @@ -32,19 +40,34 @@ struct of_device_id arr[] = { > + }, > + { } > }; > +| > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > + ..., > + { ..., E, ... }, > ++ { }, > +}; > +) > > @r depends on org || report@ > position p1; > identifier var, arr; > expression E; > @@ > -struct of_device_id arr[] = { > +( > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > ..., > { > .var = E, > } > @p1 > }; > +| > +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = { > + ..., > + { ..., E, ... } > + @p1 > +}; > +) > > @script:python depends on org@ > p1 << r.p1; > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists