linux-kernel - Re: Linux 4.1 WARNING in drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150623132941.GC25769@phenom.ffwll.local>
Date:	Tue, 23 Jun 2015 15:29:41 +0200
From:	Daniel Vetter <daniel@...ll.ch>
To:	Fabio Coatti <fabio.coatti@...il.com>
Cc:	Daniel Vetter <daniel@...ll.ch>,
	Daniel Stone <daniel@...ishbar.org>,
	David Airlie <airlied@...ux.ie>,
	dri-devel <dri-devel@...ts.freedesktop.org>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: Linux 4.1 WARNING in drm_ioctl.c

On Tue, Jun 23, 2015 at 12:46:09PM +0200, Fabio Coatti wrote:
> In data martedì 23 giugno 2015 11:48:47, Daniel Vetter ha scritto:
> > On Tue, Jun 23, 2015 at 08:27:13AM +0100, Daniel Stone wrote:
> > > Hi,
> > > 
> > > On 23 June 2015 at 07:39, Daniel Vetter <daniel@...ll.ch> wrote:
> > > > Which drm driver are you using? I didn't spot anything in your module
> > > > list
> > > > but might have missed it. Booting with drm.debug=0xe and grabbing dmesg
> > > > will tell us for sure.
> > > 
> > > That'd be vgem.
> > 
> > If so then the below diff should help.
> > -Daniel
> > diff --git a/drivers/gpu/drm/vgem/vgem_drv.c
> > b/drivers/gpu/drm/vgem/vgem_drv.c index 7a207ca547be..b491fb32cddb 100644
> > --- a/drivers/gpu/drm/vgem/vgem_drv.c
> > +++ b/drivers/gpu/drm/vgem/vgem_drv.c
> > @@ -328,6 +328,8 @@ static int __init vgem_init(void)
> >  		goto out;
> >  	}
> > 
> > +	drm_dev_set_unique(drm, "vgem");
> > +
> >  	ret  = drm_dev_register(vgem_device, 0);
> > 
> >  	if (ret)
> 
> 
> Not really sure about "drm" in drm_dev_set_unique():
> 
>   CHK     include/generated/compile.h
>   GZIP    kernel/config_data.gz
>   CHK     kernel/config_data.h
>   CC      drivers/gpu/drm/vgem/vgem_drv.o
> drivers/gpu/drm/vgem/vgem_drv.c: In function ‘vgem_init’:
> drivers/gpu/drm/vgem/vgem_drv.c:331:21: error: ‘drm’ undeclared (first use in 
> this function)

s/drm/vgem_device/ ... copypaste fail without running gcc.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/