linux-kernel - Re: [PATCH v5 5/5] usb: gadget: udc-core: independent registration of gadgets and gadget drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2015 10:08:41 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ruslan Bilovol <ruslan.bilovol@...il.com>
cc:	balbi@...com, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <k.opasiak@...sung.com>,
	<peter.chen@...escale.com>, <gregkh@...uxfoundation.org>,
	<andrzej.p@...sung.com>, <maxime.ripard@...e-electrons.com>
Subject: Re: [PATCH v5 5/5] usb: gadget: udc-core: independent registration
 of gadgets and gadget drivers

On Tue, 23 Jun 2015, Ruslan Bilovol wrote:

> Change behavior during registration of gadgets and
> gadget drivers in udc-core. Instead of previous
> approach when for successful probe of usb gadget driver
> at least one usb gadget should be already registered
> use another one where gadget drivers and gadgets
> can be registered in udc-core independently.
> 
> Independent registration of gadgets and gadget drivers
> is useful for built-in into kernel gadget and gadget
> driver case - because it's possible that gadget is
> really probed only on late_init stage (due to deferred
> probe) whereas gadget driver's probe is silently failed
> on module_init stage due to no any UDC added.
> 
> Also it is useful for modules case - now there is no
> difference what module to insert first: gadget module
> or gadget driver one.
> 
> Tested-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@...il.com>

> @@ -484,6 +507,16 @@ int usb_gadget_unregister_driver(struct usb_gadget_driver *driver)
>  			break;
>  		}
>  
> +	if (ret) {
> +		struct usb_gadget_driver *tmp;
> +
> +		list_for_each_entry(tmp, &gadget_driver_pending_list, pending)
> +			if (tmp == driver) {
> +				list_del(&driver->pending);
> +				ret = 0;
> +				break;
> +			}
> +	}

Weren't you going to replace this loop with a simple list_del()?  IIRC,
this is the third time I have asked you to make this change.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/