lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Tue, 23 Jun 2015 07:35:33 -0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Vaishali Thakkar <vthakkar1994@...il.com>,
	Doug Ledford <dledford@...hat.com>
CC:	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX

On 06/22/15 21:41, Vaishali Thakkar wrote:
>   	if (!slot || slot > 16) {
>   		mad->mad_hdr.status
> -			= __constant_cpu_to_be16(DM_MAD_STATUS_INVALID_FIELD);
> +			= cpu_to_be16(DM_MAD_STATUS_INVALID_FIELD);
>   		return;
>   	}

Without this change several statements exceeded 80 characters and were 
split because of that reason. Please change the multi-line statements 
that have been reduced to less than 80 columns into single-line statements.

Bart.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ