linux-kernel - Re: [PATCH 01/17] phy: ti-pipe3: use ti_pipe3_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150623174723.f6d28a668421d6c16289770f@ti.com>
Date:	Tue, 23 Jun 2015 17:47:23 +0300
From:	Roger Quadros <rogerq@...com>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	<bcousson@...libre.com>, <tony@...mide.com>, <balbi@...com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-omap@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-usb@...r.kernel.org>, <robh+dt@...nel.org>,
	<pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<linux@....linux.org.uk>, <gregkh@...uxfoundation.org>,
	<nsekhar@...com>
Subject: Re: [PATCH 01/17] phy: ti-pipe3: use ti_pipe3_power_off to power
 off the PHY during probe

On Tue, 23 Jun 2015 17:28:46 +0530
Kishon Vijay Abraham I <kishon@...com> wrote:

> No functional change. Previously omap_control_phy_power() was used to power
> off the PHY during probe. But once PIPE3 driver is adapted to use syscon,
> omap_control_phy_power() cannot be used. Hence used ti_pipe3_power_off
> to power off the PHY.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>

Acked-by: Roger Quadros <rogerq@...com>

cheers,
-roger

> ---
>  drivers/phy/phy-ti-pipe3.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-ti-pipe3.c b/drivers/phy/phy-ti-pipe3.c
> index 08020dc..d784426 100644
> --- a/drivers/phy/phy-ti-pipe3.c
> +++ b/drivers/phy/phy-ti-pipe3.c
> @@ -431,8 +431,6 @@ static int ti_pipe3_probe(struct platform_device *pdev)
>  
>  	phy->control_dev = &control_pdev->dev;
>  
> -	omap_control_phy_power(phy->control_dev, 0);
> -
>  	platform_set_drvdata(pdev, phy);
>  	pm_runtime_enable(phy->dev);
>  
> @@ -451,6 +449,8 @@ static int ti_pipe3_probe(struct platform_device *pdev)
>  		return PTR_ERR(generic_phy);
>  
>  	phy_set_drvdata(generic_phy, phy);
> +	ti_pipe3_power_off(generic_phy);
> +
>  	phy_provider = devm_of_phy_provider_register(phy->dev,
>  			of_phy_simple_xlate);
>  	if (IS_ERR(phy_provider))
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/