linux-kernel - Re: [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4fcf5e480035d355525306fc8743bac.squirrel@www.codeaurora.org>
Date:	Tue, 23 Jun 2015 09:16:39 -0600
From:	"Ankit Gupta" <ankgupta@...eaurora.org>
To:	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	"Ankit Gupta" <ankgupta@...eaurora.org>, rostedt@...dmis.org,
	mingo@...hat.com, agross@...eaurora.org, davem@...emloft.net,
	rdunlap@...radead.org, standby24x7@...il.com, sboyd@...eaurora.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	gavidov@...eaurora.org, sdharia@...eaurora.org,
	linux-arm-msm@...r.kernel.org, mlocke@...eaurora.org
Subject: Re: [PATCH v2] trace/events: add chip name and hwirq to irq entry
 tracepoint

> On Mon, 22 Jun 2015, Ankit Gupta wrote:
>
>> Add chip name and hw-irq number to the trace_irq_handler_entry()
>> tracepoint. When tracing interrupt events the chip-name and hw-irq
>> numbers are stable and known in advance. This makes them a better
>> choice as a filtering criteria for the trace buffer dump. On the
>> flipside, the os-irq numbers are dynamically allocated which makes
>> them difficult to use for the same purpose.
>>
>> Dump messages will look like:
>> ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140

>
> I can't see the domain name being captured/printed in the code below.
>
>> -	TP_printk("irq=%d name=%s", __entry->irq, __get_str(name))
>> +	TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq,
>> +	  __get_str(name), show_chip_name(__entry->irq),
>> +	  show_hwirq(__entry->irq))
>>  );

Thanks Thomas for your comment. Its actually printing a chipname and not
the domain. Will correct the dump message in the next patch. It will print
as follow.
...irq_handler_entry: irq=22 name=msm_serial0 Chip=GIC hwirq=140

>
> Thanks,
>
> 	tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm"
> in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/