linux-kernel - Re: [v4 01/16] KVM: Extend struct pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5589801A.2090203@redhat.com>
Date:	Tue, 23 Jun 2015 17:49:46 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Feng Wu <feng.wu@...el.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	mtosatti@...hat.com, alex.williamson@...hat.com,
	eric.auger@...aro.org
Subject: Re: [v4 01/16] KVM: Extend struct pi_desc for VT-d Posted-Interrupts



On 11/06/2015 12:51, Feng Wu wrote:
> +	union {
> +		struct {
> +				/* bit 256 - Outstanding Notification */
> +			u64	on	: 1,
> +				/* bit 257 - Suppress Notification */
> +				sn	: 1,
> +				/* bit 271:258 - Reserved */
> +				rsvd_1	: 14,
> +				/* bit 279:272 - Notification Vector */
> +				nv	: 8,
> +				/* bit 287:280 - Reserved */
> +				rsvd_2	: 8,
> +				/* bit 319:288 - Notification Destination */
> +				ndst	: 32;

Please do not use bitfields, Linus doesn't like them.  Use static
inlines instead to extract or set the fields from the control field.

Paolo

> +		};
> +		u64 control;
> +	};
> +	u32 rsvd[6];
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/