linux-kernel - [PATCH 0/1] mm: move ->mremap() from file_operations to vm_operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150623180225.GA12882@redhat.com>
Date:	Tue, 23 Jun 2015 20:02:25 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andy Lutomirski <luto@...capital.net>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	Benjamin LaHaise <bcrl@...ck.org>,
	Hugh Dickins <hughd@...gle.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	Kirill Shutemov <kirill.shutemov@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andy Lutomirski <luto@...nel.org>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: [PATCH 0/1] mm: move ->mremap() from file_operations to
	vm_operations_struct

On 06/22, Andy Lutomirski wrote:
>
> On Mon, Jun 22, 2015 at 5:47 PM, Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > I never understood why ->mremap() lives in file_operations, not in
> > vm_operations_struct. To me vma->vm_file->f_op in move_vma() just
> > looks strange, vma->vm_ops->mremap(new_vma) looks "obviously better".
> >
> > And afaics more useful. CRIU remaps vdso, but this does not update
> > mm->context.vdso. OK, probably this does not matter currently, CRIU
> > can't c/r the compat tasks, and 64-bit apps do not use context.vdso.
> > Afaics. Still, I think we might want to have special_mapping_remap()
> > and we can't do this because ->vm_file == NULL.
>
> I would like this.  Then I could clean up and resubmit my patch to
> keep context.vdso up to date.

Cough... where can I find this patch ? ;)

> Oleg, can you let me know what patch, if any, I should be reviewing?

This one, it looks really trivial. And of course I will appreciate it
if you can review the special_mapping_fault() fixes.

The change in move_vma() textually depends on another patch I sent,

	[PATCH 1/4] mremap: don't leak new_vma if f_op->mremap() fails
	http://marc.info/?l=linux-kernel&m=143475603713622

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/