linux-kernel - Re: [PATCH 6/6] mtd: docg3: Don't do ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871th2kvia.fsf@belgarion.home>
Date:	Tue, 23 Jun 2015 22:41:33 +0200
From:	Robert Jarzmik <robert.jarzmik@...e.fr>
To:	Richard Weinberger <richard@....at>
Cc:	Brian Norris <computersforpeace@...il.com>,
	linux-mtd@...ts.infradead.org, dwmw2@...radead.org,
	maximlevitsky@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] mtd: docg3: Don't do ERR_PTR(0)

Richard Weinberger <richard@....at> writes:

> Am 17.06.2015 um 20:41 schrieb Brian Norris:
>> On Mon, Jun 01, 2015 at 11:10:54PM +0200, Richard Weinberger wrote:
>>> Don't return a obfuscated null pointer using ERR_PTR(0).
>>> If the no device is found clearly return -ENODEV.
>>> This makes the code more clear and matches the comment
>>> of doc_probe_device().
>>>
>>> Signed-off-by: Richard Weinberger <richard@....at>
>>> ---
>> 
>> Have you tested this patch?
>
> nah, I don't own such a device.
But I do. If you resend a patch, please Cc me. You can even ask for a test from
time to time if you want a confirmation, I have a 2 floors docg3 device.

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/