[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150623215434.GA24969@krava.brq.redhat.com>
Date: Tue, 23 Jun 2015 23:54:34 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Jiri Olsa <jolsa@...nel.org>, lkml <linux-kernel@...r.kernel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
Andi Kleen <ak@...ux.intel.com>,
David Ahern <dsahern@...il.com>,
Ingo Molnar <mingo@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 03/27] perf tools: Add reference counting for cpu_map
object
On Tue, Jun 23, 2015 at 06:06:45PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jun 23, 2015 at 12:36:04AM +0200, Jiri Olsa escreveu:
> > -void cpu_map__delete(struct cpu_map *map)
> > +static void cpu_map__delete(struct cpu_map *map)
> > {
> > - free(map);
> > + if (map) {
> > + WARN_ONCE(atomic_read(&map->refcnt) != 0,
> > + "cpu map refcnt disbalanced\n");
>
> Have you used this to catch some bug or is this just some attempt at a
> proactive check? s/disbalanced/unbalanced/g
yep, proactive check
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists