linux-kernel - Re: [PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <558A45F0.2010601@samsung.com>
Date:	Wed, 24 Jun 2015 07:53:52 +0200
From:	Andrzej Hajda <a.hajda@...sung.com>
To:	Antonio Borneo <borneo.antonio@...il.com>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-media@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] [media] s5c73m3: Remove redundant spi driver bus
 initialization

On 06/23/2015 04:53 PM, Antonio Borneo wrote:
> In ancient times it was necessary to manually initialize the bus
> field of an spi_driver to spi_bus_type. These days this is done in
> spi_register_driver(), so we can drop the manual assignment.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@...il.com>
> To: Mauro Carvalho Chehab <mchehab@....samsung.com>
> To: Kyungmin Park <kyungmin.park@...sung.com>
> To: Andrzej Hajda <a.hajda@...sung.com>
> To: linux-media@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org

Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

Regards
Andrzej
> ---
>  drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> index 63eb190..fa4a5eb 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-spi.c
> @@ -149,7 +149,6 @@ int s5c73m3_register_spi_driver(struct s5c73m3 *state)
>  	spidrv->remove = s5c73m3_spi_remove;
>  	spidrv->probe = s5c73m3_spi_probe;
>  	spidrv->driver.name = S5C73M3_SPI_DRV_NAME;
> -	spidrv->driver.bus = &spi_bus_type;
>  	spidrv->driver.owner = THIS_MODULE;
>  	spidrv->driver.of_match_table = s5c73m3_spi_ids;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/